On Wed, Aug 27, 2014 at 06:52:57PM +0100, Chris Wilson wrote: > > Just to clarify, he was not ok because the list we maintain in the > > test can get out of sync with the workarounds we apply in the driver > > which can be avoided if it is generated by the kernel itself. > > Test driven development would suggest that the test itself maintains its > list. Something I heard Daniel say himself before ;-) > > > It may be ok to maintain the list in the test in this case > > considering the list is fairly small but it is not my call. > > The best thing about independent testing is that it is independent... Well also depends on what you're testing I suppose. It's hard enough to have a complete list of W/As, so two of them is bound to end up in tears. If we are testing that the list of W/As the kernel knows about is indeed applied correctly at init/reset/suspend resume, that's already a good step. Also, that second list in i-g-t is not going to be implemented in complete independence from the kernel tree, it's likely to be the same person doing both sides, ending up copy/pasting a file anyway, no value in doing that. The two lists argument works well if 2 different engineers/teams implement the 2 sides, effective cross-checking the list of W/As as a result, but we don't quite have the people to do that. -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
