On Thu, Aug 21, 2014 at 10:57:09AM +0000, Daniel, Thomas wrote: > > > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel > > Vetter > > Sent: Friday, August 15, 2014 1:14 PM > > To: Daniel, Thomas > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Mika Kuoppala > > Subject: Re: [PATCH 35/43] drm/i915/bdw: Make sure error > > capture keeps working with Execlists > > > > On Thu, Jul 24, 2014 at 05:04:43PM +0100, Thomas Daniel wrote: > > > From: Oscar Mateo <oscar.mateo@xxxxxxxxx> > > > > > > Since the ringbuffer does not belong per engine anymore, we have to > > > make sure that we are always recording the correct ringbuffer. > > > > > > TODO: This is only a small fix to keep basic error capture working, > > > but we need to add more information for it to be useful (e.g. dump the > > > context being executed). > > > > > > v2: Reorder how the ringbuffer is chosen to clarify the change and > > > rename the variable, both changes suggested by Chris Wilson. Also, add > > > the TODO comment to the code, as suggested by Daniel. > > > > > > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> > > > > There's a bit too much stuff in-flight to fix up error capture for ppgtt. > > I think it's better to stall this patch here until that work is completed. > > Please coordinate with Mika here. > > -Daniel > Mika has now closed the Jira issue. This patch still applies and looks > correct. Is it OK to be merged as-is? Apparently Mika closed the Jira before I've merged all the patches. I'd like to do that first, then come back to this patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
