> -----Original Message----- > From: Lespiau, Damien > Sent: Friday, August 01, 2014 3:46 PM > To: Daniel, Thomas > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 34/43] drm/i915/bdw: Make sure gpu reset > still works with Execlists > > On Thu, Jul 24, 2014 at 05:04:42PM +0100, Thomas Daniel wrote: > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c > b/drivers/gpu/drm/i915/intel_ringbuffer.c > > index 3188403..6e604c9 100644 > > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > > @@ -1587,6 +1587,7 @@ static int intel_init_ring_buffer(struct drm_device > *dev, > > ring->dev = dev; > > INIT_LIST_HEAD(&ring->active_list); > > INIT_LIST_HEAD(&ring->request_list); > > + INIT_LIST_HEAD(&ring->execlist_queue); > > It's also a bit weird to now have sites where we initialize this list. > or I'm missing something? The legacy ringbuffer init path now also has to initialize the queue because I915_gem_reset_ring_cleanup() now assumes that the list is always valid, even though it will always be empty in legacy mode. > > -- > Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
