Re: [RFC v2 2/3] drm/i915: duplicate i915_gem_ring_dispatch trace and add ctx parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I would also like a better ctx identifier than its pointer. Using the
pointer for tracking objects makes it more difficult to read traces
(although it is easy for scripts).

I use the VM pointer to track the ppgtt; that pointer is also printed by
several other traces, including the ppgtt init/release ones that I've
submitted for comments in this series. However, I don't mind changing
the way we identify the ctx as long as I still have access to the VM
pointer. I'll have a look at the possible ways of identifying the ctx
and I'll try to find a better solution than the current one.


I've looked for other ways to identify the ctx, but I could't find anything more readable than a pointer. The best alternative in my opinion is to use the user_handle, but that is dependent on the file_priv so it is not enough on its own. Coupling the user_handle with the file_priv pointer doesn't seem like a good idea, so I still think that using the ctx pointer or the vm pointer is the best way to identify the ctx at the moment. Did you have something in mind that I've missed?

Thanks,
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux