On Wed, Jul 09, 2014 at 10:29:09AM +0100, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > > This should hopefully simplify the display code slightly and also > > solves at least one mistake in intel_pipe_set_base() where > > to_intel_framebuffer(fb)->obj is referenced during local variable > > initialization, before 'if (!fb)' gets checked. > > > > Potential uses of this macro were identified via the following > > Coccinelle patch: > > > > @@ > > expression E; > > @@ > > * to_intel_framebuffer(E)->obj > > > > @@ > > expression E; > > identifier I; > > @@ > > I = to_intel_framebuffer(E); > > ... > > * I->obj > > > > v2: Rewrite some NULL tests in terms of the obj rather than the fb. > > Also add a WARN() if trying to pageflip with a disabled primary > > plane. [Suggested by Chris Wilson] > > > > Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > And iirc 1/2 was trivial, so r-b for that as well. Thanks, both merged to dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
