On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > This should hopefully simplify the display code slightly and also > solves at least one mistake in intel_pipe_set_base() where > to_intel_framebuffer(fb)->obj is referenced during local variable > initialization, before 'if (!fb)' gets checked. > > Potential uses of this macro were identified via the following > Coccinelle patch: > > @@ > expression E; > @@ > * to_intel_framebuffer(E)->obj > > @@ > expression E; > identifier I; > @@ > I = to_intel_framebuffer(E); > ... > * I->obj > > v2: Rewrite some NULL tests in terms of the obj rather than the fb. > Also add a WARN() if trying to pageflip with a disabled primary > plane. [Suggested by Chris Wilson] > > Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> And iirc 1/2 was trivial, so r-b for that as well. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
