Re: [PATCH 1/8] drm/i915: Extract context backing object allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 08, 2014 at 10:39:26AM +0100, Chris Wilson wrote:
> On Thu, Jul 03, 2014 at 04:27:58PM +0100, oscar.mateo@xxxxxxxxx wrote:
> > From: Oscar Mateo <oscar.mateo@xxxxxxxxx>
> > 
> > This is preparatory work for Execlists: we plan to use it later to
> > allocate our own context objects (since Logical Ring Contexts do
> > not have the same kind of backing objects).
> > 
> > No functional changes.
> > 
> > Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
> 
> The series looks fine. My gripe is that the split between context and
> ring is messy (I think that a context is now a view of the entire
> hardware state and so our bookkeeping should reflect that) and leads to
> some subtle bugs where the bookkeeping on the ring is not transferred
> correctly to the context. However, this series is a good starting point
> to fix the more esoteric problems.
> 
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Thanks for patches & review, all merged to dinq.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux