Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs.

[Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>]

Hi Daniel,

please consider to merge the first version. So we can move fwd with ddx patche followed by proper marketing names.

Thanks,

Rodrigo.

On Wed, Jun 11, 2014 at 10:47 AM, Ben Widawsky <ben@xxxxxxxxxxxx> wrote:

On Tue, Jun 10, 2014 at 10:41:07AM -0700, Rodrigo Vivi wrote:
> These PCI IDs are reserved on BSpec and can be used at any time in the future.
> So let's add this now in order to avoid issues that we already faced on previous
> platforms, like finding out about new ids when user reported accelaration weren't
> enabled.
>
> v2: Reserved IDs doesn't have GT defined. So, creating a separated list. (Ben)
>
> Cc: Ben Widawsky <ben@xxxxxxxxxxxx>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> ---
>  include/drm/i915_pciids.h | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 0572035..0968478 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -237,13 +237,25 @@
>  #define INTEL_BDW_GT3D_IDS(info) \
>       _INTEL_BDW_D_IDS(3, info)
>
> +#define INTEL_BDW_RSVDM_IDS(info) \
> +     INTEL_VGA_DEVICE(0x1632, info), \
> +     INTEL_VGA_DEVICE(0x1636, info), \
> +     INTEL_VGA_DEVICE(0x163B, info), \
> +     INTEL_VGA_DEVICE(0x163A, info)
> +
> +#define INTEL_BDW_RSVDD_IDS(info) \
> +     INTEL_VGA_DEVICE(0x163D, info), \
> +     INTEL_VGA_DEVICE(0x163E, info)
> +
>  #define INTEL_BDW_M_IDS(info) \
>       INTEL_BDW_GT12M_IDS(info), \
> -     INTEL_BDW_GT3M_IDS(info)
> +     INTEL_BDW_GT3M_IDS(info), \
> +     INTEL_BDW_RSVDM_IDS(info)
>
>  #define INTEL_BDW_D_IDS(info) \
>       INTEL_BDW_GT12D_IDS(info), \
> -     INTEL_BDW_GT3D_IDS(info)
> +     INTEL_BDW_GT3D_IDS(info), \
> +     INTEL_BDW_RSVDD_IDS(info)
>
>  #define INTEL_CHV_IDS(info) \
>       INTEL_VGA_DEVICE(0x22b0, info), \

I thought we saved off the GT info, but now that I actually look at the
code, we do not. Therefore, I actually think v1 is a better patch.

In either case, both v1 and v2 are:
Reviewed-by: Ben Widawsky <ben@xxxxxxxxxxxx>

I apologize for the extra work.

--
Ben Widawsky, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--

Rodrigo Vivi

Blog: http://blog.vivi.eng.br

 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx