Hi Damien, Can you please point out these, as this patch is re-based on latest 2/3, I was expecting this to be without any inconsistency. I personally checked for any <80 char formatting, which is not required. But if I missed any, I can again fix this, please let me know. Regards Shashank -----Original Message----- From: Lespiau, Damien Sent: Monday, June 02, 2014 6:22 PM To: Sharma, Shashank Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx; Vetter, Daniel; Kumar, Shobhit Subject: Re: [PATCH 3/3] drm/i915: Use transcoder as index to MIPI regs On Mon, Jun 02, 2014 at 06:07:48PM +0530, shashank.sharma@xxxxxxxxx wrote: > From: Shashank Sharma <shashank.sharma@xxxxxxxxx> > > Conceptually, the MIPI registers are addressed by the MIPI transcoder > index, not the pipe. It doesn't matter right now, because there's a > 1:1 relationship between pipes and MIPI transcoders, but that change > allows us to break that link in the future > > V1: Created new patch to address Damien's review comment. > Replacing _PIPE calls to _TRANSCODER calls > V2: Re-basing on patch 2 > V3: Re-basing on patch 2 > V4: Re-basing on patch 2 > > Signed-off-by: Shashank Sharma <shashank.sharma@xxxxxxxxx> You still have a few inconsistencies here and there because you tried to get everything under 80 chars in a previous version. Oh well. I guess we can have a pass on top if someone's OCD is uncontrollable. Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
