Hi On Mon, May 19, 2014 at 4:53 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Mon, May 19, 2014 at 04:44:15PM +0200, David Herrmann wrote: >> On Mon, May 19, 2014 at 4:41 PM, Thomas Wood <thomas.wood@xxxxxxxxx> wrote: >> > It was intended as a debug/testing feature to allow tests in >> > intel-gpu-tools to enable or disable connectors: >> > >> > http://lists.freedesktop.org/archives/intel-gfx/2014-May/045556.html >> > >> > >> > I'll update the commit message for the next version of the patch. >> >> Thanks! But please make it a debugfs feature, if possible. We >> shouldn't expose interfaces in sysfs that aren't part of the core API. >> Note that this might require you to encode the connector-name in the >> debugfs-attribute-name. > > Imo having the read and write side in completely different parts doesn't > make a lot of sense. Hence I think doing this in sysfs is ok. Also users > might want to frob this for testing, and usually debugfs is a bit further > away on most systems. So the read-side is not debug-only? That wasn't clear to me. In that case, I'm fine with keeping it in sysfs, although I'm not entirely sure why anyone is interested in "force" information. Thanks David _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
