Hi On Mon, May 19, 2014 at 4:41 PM, Thomas Wood <thomas.wood@xxxxxxxxx> wrote: > On 19 May 2014 15:13, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: >> Hi >> >> On Mon, May 19, 2014 at 3:37 PM, Thomas Wood <thomas.wood@xxxxxxxxx> wrote: >>> Signed-off-by: Thomas Wood <thomas.wood@xxxxxxxxx> >> >> The commit-msg lacks any discussion why this change is done. What is >> the reason to do that? Isn't the kernel-command-line enough? Why is >> this a regular feature instead of a debugfs attribute? > > > It was intended as a debug/testing feature to allow tests in > intel-gpu-tools to enable or disable connectors: > > http://lists.freedesktop.org/archives/intel-gfx/2014-May/045556.html > > > I'll update the commit message for the next version of the patch. Thanks! But please make it a debugfs feature, if possible. We shouldn't expose interfaces in sysfs that aren't part of the core API. Note that this might require you to encode the connector-name in the debugfs-attribute-name. Thanks David _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
