On Wed, May 14, 2014 at 11:53:46AM +0000, Mateo Lozano, Oscar wrote: > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel Vetter > > Sent: Tuesday, May 13, 2014 2:27 PM > > To: Mateo Lozano, Oscar > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Ben Widawsky; Widawsky, Benjamin > > Subject: Re: [PATCH 04/50] drm/i915: Extract trivial parts of ring init > > (early init) > > > > On Fri, May 09, 2014 at 01:08:34PM +0100, oscar.mateo@xxxxxxxxx wrote: > > > From: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> > > > > > > It's beneficial to be able to get a name, base, and id before we've > > > actually initialized the rings. This ability was effectively destroyed > > > in the ringbuffer fire which Daniel started. > > > > > > With the simple early init function, that ability is restored. > > > > > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> > > > > > > v2: The Full PPGTT series have moved things around a little bit. > > > Also, don't forget the VEBOX. > > > > > > v3: Checking ring->dev is not a good way to test if a ring is > > > initialized... > > > > > > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> > > > > Needs to be updated for VEBOX2. Also I don't really see the point, where > > exactly do we need this? Ripping apart the ring init like this doesn't look too > > great imo. > > VEBOX2?? Not one week ago I updated it for BSD2 :( > Anyway, this patch is a legacy carry over from previous versions, I can perfectly make do without it. Oops, I've meant VCS2, must have been asleep while reading it ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
