On Tue, May 13, 2014 at 03:26:51PM +0200, Daniel Vetter wrote: > On Fri, May 09, 2014 at 01:08:34PM +0100, oscar.mateo@xxxxxxxxx wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > > index 2d81985..8f37238 100644 > > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > > @@ -886,7 +886,7 @@ static void i915_gem_record_rings(struct drm_device *dev, > > for (i = 0; i < I915_NUM_RINGS; i++) { > > struct intel_ring_buffer *ring = &dev_priv->ring[i]; > > > > - if (ring->dev == NULL) > > + if (!intel_ring_initialized(ring)) > > continue; Besides this was deliberately written not to use intel_ring_initialized(). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx