On Tue, Apr 8, 2014 at 8:58 AM, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > Before the conversion to dp aux helpers there was a switch case [1] that > ended up in msg_bytes = 3 for address only start/stop messages > (MODE_I2C_START or MODE_I2C_STOP bit set [2]). With Alex's series in, > but without my patch, we'd send the four byte header but with 0 - 1 = > 0xff in txbuf[3]. I'm pretty sure breakage would follow. > > Thus I'd like to have my patch in before the dp aux helpers use > msg->size == 0 for address only messages. > > Daniel, convinced yet? Indeed, I've been blinding. Acked for merging through radeon trees together with the other patches as a fixup for 3.15. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
