On Sat, Apr 05, 2014 at 07:24:01AM +0100, Chris Wilson wrote: > On Fri, Apr 04, 2014 at 10:41:07PM -0700, Ben Widawsky wrote: > > I opted to do this instead of grabbing the context reference after > > eb_create since eb_create can potentially call the shrinker, and that > > makes things very complicated. This simple patch balances the ref count > > without requiring a great deal of review to make sure the shrinker path > > is safe. > > > > Theoretically (by design) the shrinker can end up destroying a context, > > which enforces the reasoning for doing the fix this way instead of > > moving the reference to later in the function. > > > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx> > > Even the whitespace fix is correct. > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx