Re: [PATCH] drm/i915: Unref context on failed eb_create

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 04, 2014 at 10:41:07PM -0700, Ben Widawsky wrote:
> I opted to do this instead of grabbing the context reference after
> eb_create since eb_create can potentially call the shrinker, and that
> makes things very complicated. This simple patch balances the ref count
> without requiring a great deal of review to make sure the shrinker path
> is safe.
> 
> Theoretically (by design) the shrinker can end up destroying a context,
> which enforces the reasoning for doing the fix this way instead of
> moving the reference to later in the function.
> 
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ben Widawsky <ben@xxxxxxxxxxxx>

Even the whitespace fix is correct.
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux