Re: [PATCH] drm/i915: sprinkle static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 02, 2014 at 09:20:56PM +0100, Daniel Vetter wrote:
> Apparently we've missed a few more than what Fengguang's 0-day tester
> recently reported in i915_irq.c ... Makes sparse happy again (ignore
> some spurious stuff about ksyms of exported functions).
> 
> Cc: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/i915_irq.c      |  4 ++--
>  drivers/gpu/drm/i915/intel_display.c | 10 +++++-----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 69f2ebbd6af1..484415bb3497 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -482,7 +482,7 @@ done:
>  }
>  
>  
> -void
> +static void
>  __i915_enable_pipestat(struct drm_i915_private *dev_priv, enum pipe pipe,
>  		       u32 enable_mask, u32 status_mask)
>  {
> @@ -506,7 +506,7 @@ __i915_enable_pipestat(struct drm_i915_private *dev_priv, enum pipe pipe,
>  	POSTING_READ(reg);
>  }
>  
> -void
> +static void
>  __i915_disable_pipestat(struct drm_i915_private *dev_priv, enum pipe pipe,
>  		        u32 enable_mask, u32 status_mask)
>  {
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c559c58af483..863500893e96 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7692,7 +7692,7 @@ err:
>  	return ERR_PTR(ret);
>  }
>  
> -struct drm_framebuffer *
> +static struct drm_framebuffer *
>  intel_framebuffer_create(struct drm_device *dev,
>  			 struct drm_mode_fb_cmd2 *mode_cmd,
>  			 struct drm_i915_gem_object *obj)
> @@ -10541,10 +10541,10 @@ static const struct drm_framebuffer_funcs intel_fb_funcs = {
>  	.create_handle = intel_user_framebuffer_create_handle,
>  };
>  
> -int intel_framebuffer_init(struct drm_device *dev,
> -			   struct intel_framebuffer *intel_fb,
> -			   struct drm_mode_fb_cmd2 *mode_cmd,
> -			   struct drm_i915_gem_object *obj)
> +static int intel_framebuffer_init(struct drm_device *dev,
> +				  struct intel_framebuffer *intel_fb,
> +				  struct drm_mode_fb_cmd2 *mode_cmd,
> +				  struct drm_i915_gem_object *obj)
>  {
>  	int aligned_height;
>  	int pitch_limit;
> -- 
> 1.8.5.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux