Re: [PATCH 2/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 10, 2014 at 02:53:29PM +0200, Ville Syrjälä wrote:
> > Since every access should now go through the macro I think it'd be good to
> > give this a __ prefix to make it clear that users better think twice
> > before using it. Maybe as a patch on top of all this?
> 
> No. Everyone having to use the macro was a requirement of the v2 patch.
> With v3 that requirement was lifted since the const is right there on
> the struct itself. I think that was the whole point of v3.

The "everyone should now go through the macro" is not for the const.
There's a new idea floating around to replace the macros by hardcoded
values to be able to compile the driver for a specific platform and use
the compiler dead code elimiation pass(es) to reduce the text size.

There may be more cunning ways to reduce the driver size, haven't
thought much about it.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux