On Wed, 05 Feb 2014, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Tue, Feb 04, 2014 at 09:35:46PM +0200, Imre Deak wrote: >> This will be used by other platforms too, so factor it out. >> >> The only functional change is the reordeing of gmbus_irq_handler() wrt. >> the hotplug handling, but since it only schedules a work, it isn't an >> issue. >> >> Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/i915_irq.c | 76 +++++++++++++++++++++++------------------ >> 1 file changed, 42 insertions(+), 34 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> index 137ac65..b5524ea 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -1477,15 +1477,53 @@ static void gen6_rps_irq_handler(struct drm_i915_private *dev_priv, u32 pm_iir) >> } >> } >> >> +static void valleyview_pipestat_irq_handler(struct drm_device *dev, u32 iir) >> +{ >> + drm_i915_private_t *dev_priv = dev->dev_private; > > typedefs for structs are frowned upon. I've fixed this while applying. sed -i -e 's/drm_i915_private_t/struct drm_i915_private/' *.[ch] plus a little hand-editing and be done with it...? -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx