Re: [RFC 00/22] Gen7 batch buffer command parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 5, 2014 at 8:00 PM, Volkin, Bradley D
<bradley.d.volkin@xxxxxxxxx> wrote:
> To test/merge, we'd have to change the series to take out the part where
> patch 02/13 sets I915_DISPATCH_SECURE to avoid a BUG_ON() when i915.enable_cmd_parser=1.
> But yes, otherwise the parsing works and I think should be sufficient for
> what Chris indicated he wants to test.

Oh, I didn't spot this but this needs to be moved way back in the
series - we can only set the bit once we have the batchbuffer copy
logic in place. Otherwise there's a security hole open since userspace
is free to frob the batch residing in the ppgtt, which we just can't
prevent.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux