On Fri, Jan 24, 2014 at 04:14:10PM +0200, Ville Syrjälä wrote: > On Fri, Jan 24, 2014 at 07:18:43PM +0530, sagar.a.kamble@xxxxxxxxx wrote: > > From: Sagar Kamble <sagar.a.kamble@xxxxxxxxx> > > > > This patch enables 180 degree rotation for primary and sprite planes > > through sysfs interface. > > NAK. > > See here for the right apporach: > http://lists.freedesktop.org/archives/intel-gfx/2013-September/033951.html And BTW if you're really interested in getting this stuff in, we (Daniel actually :) need tests in i-g-t. We have the display CRC stuff availalbe, so fully automated tests are possible for this stuff. So this is definitely one area where we're lacking manpower. Some ideas for simple sprite tests: - make sure it appears on the right spot on the screen - make sure it doesn't appear when off screen - make sure it clips correctly when partially off screen - repeat everything w/ 180 degree rotation One idea for a color key test: - clear primary to solid color (or some fancier image) - clear sprite to another color (or some fancier image) - fill a small rect in the color key on the primary - place the sprite on top of the color keyed are but make it slightly bigger than the area, and make sure only the color keyed area shows the sprite So this would all involve rendering the reference images w/ software, and then reproducing the expected result using the sprite, and making sure it all matches up. Finally come up with more tests as more properties get added (z order, blending, etc.). -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
