On Thu, Jan 23, 2014 at 7:07 AM, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Wed, 22 Jan 2014, Daniel Vetter <daniel@xxxxxxxx> wrote: >> Just figured I'll comment on these two issues, patches themselves look >> really nice \o/ > > Look nice they do, but it also makes me a little sad that neither git > grep nor my source code tagging system will no longer find where the > registers are accessed. They are quite powerful tools. Hm, tbh I haven't considered that. But even with that I think the consistency we gain is worth it, especially since it's all contained to i915_irq.c. And it's not really the first time we break grep for register definitions, we have lots of base address + offset all over the place, sometimes even with magic offset only (e.g. the dp aux code). Also ime the most useful case for grepping is for the random obscure registers which tend to pop up only on a few platforms (or get moved around like crazy), where we need to frob some specific bits for e.g. a w/a. For those it's really useful to reliable be able to grep all use-sites. The I[ISME]R registers imo don't fit into this pattern really. So still in favour. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
