On 1/17/2014 6:32 AM, Jani Nikula wrote:
On Fri, 17 Jan 2014, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote:
I see spaces instead of tabs. You can use the useful checkpatch.pl
script on patches to catch those pesky style issues (from within a linux
tree):
$ ./scripts/checkpatch.pl 0001-drm-i915-Enable-5.4Ghz-HBR2-link-rate-for-Displaypor.patch
[...]
total: 6 errors, 9 warnings, 55 lines checked
Should anyone find this useful, I have these to check branches in my
local repos directly:
alias checkpatch='/path/to/checkpatch.pl -q --emacs --strict'
checkbranch()
{
local commit
local range
if [ -z "$1" ]; then
range="origin..HEAD"
elif [ -n "`echo $1 | grep '\.\.'`" ]; then
range="$1"
else
range="$1..HEAD"
fi
for commit in `git rev-list --reverse $range`; do
git --no-pager log --oneline -1 $commit
git format-patch --stdout -1 $commit | checkpatch -
done
}
Then I can do:
Check local patches against origin:
$ checkbranch
Check local patches against drm-intel/drm-intel-nightly:
$ checkbranch drm-intel/drm-intel-nightly
Check a revision range:
$ checkbranch commit1..commit2
Do note that checkpatch is not the law. But it helps you get some of the
little things straight.
HTH,
Jani.
Cool thanks Jani. I'll give that a try.
-T
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
