2013/12/19 Daniel Vetter <daniel@xxxxxxxx>: > On Thu, Dec 19, 2013 at 7:30 PM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: >> So we have these runtime_pm_get/put calls all over now. Is the plan to >> convert those to specific wells as we add support for new platforms so >> we can have fine grained well control rather than just global control? >> I guess I need to dig out Imre's latest stuff and check... > > My idea was that the power well stuff was just for the display side, > since there the hw engineers love to slice&dice things up in always > new ways. Other parts of the driver call get/put on specific power > domain functions (atm pc8+D3, but soon only D3). I'm open to suggestions. This series removes all the calls to PC8 get/put, leaving only the "runtime PM" get/put and "power domains" get/put, so IMHO we already do some cleanup. Since Imre's recent rework I actually started to like the power domains, and IMHO a nice approach for the future would be to add power domains as needed and replace the "runtime PM get/put" calls with proper power domain get/put calls. On this series there's a patch that makes us get runtime PM every time we get a power domain, so it should be easy to just add new domains. And I think it makes sense to also add power domains for non-display things (as long as we rename intel_display_power_{get,put} to intel_power_domain_{get,put}. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx