Re: [PATCH] i915/gt: Move context wa to appropriate *_ctx_workarounds_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sebastian,

> According to bspecs, CACHE_MODE_0 and  CACHE_MODE_1 are saved and
> restored as part of Context. Let's move it to `ctx_workaround_init` instead
> of `rcs_engine_wa_init`, this way workarounds are applied and saved into
> the default context.

These flags are already used a bit inconsistently in this file.
Before this patch CACHE_MODE_0_GEN7 was used in
gen8_ctx_workarounds_init() to intialize the default context,
while all remaining usages were in rcs_engine_wa_init().

After your patch the inconsistency still remains for Haswell and
for Ivybridge, but to remedy that we'd probably need to
introduce new functions "*_ctx_workarounds_init()" for those
gens to have their workarounds included during default context
initialization.

So the thing to consider here is whether we prefer these WAs to
be associated with context or RCS engine functions and commit to
one of the approaches.

Best Regards,
Krzysztof




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux