Hi Andi,
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Andi Shyti
> Sent: Friday, March 14, 2025 7:42 AM
> To: intel-gfx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>; Andi Shyti <andi.shyti@xxxxxxxxxx>
> Subject: [PATCH 3/4] drm/i915/gt: Remove trailing blank lines
>
> Remove useless blank lines before and after the brackets.
>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_gtt.c | 1 - drivers/gpu/drm/i915/gt/intel_lrc.c |
> 1 - drivers/gpu/drm/i915/gt/intel_mocs.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c
> b/drivers/gpu/drm/i915/gt/intel_gtt.c
> index 30b128b1fde7..afbc5c769308 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
> @@ -176,7 +176,6 @@ static void clear_vm_list(struct list_head *list)
> i915_vma_destroy_locked(vma);
> i915_gem_object_put(obj);
> }
> -
> }
> }
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c
> b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 51847a846002..c481b56fa67d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -751,7 +751,6 @@ static int lrc_ring_indirect_offset(const struct
> intel_engine_cs *engine)
>
> static int lrc_ring_cmd_buf_cctl(const struct intel_engine_cs *engine) {
> -
> if (GRAPHICS_VER_FULL(engine->i915) >= IP_VER(12, 55))
> /*
> * Note that the CSFE context has a dummy slot for
> CMD_BUF_CCTL diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c
> b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index cf41d325712e..5dd8121f4b15 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -314,7 +314,6 @@ static const struct drm_i915_mocs_entry
> icl_mocs_table[] = { };
>
> static const struct drm_i915_mocs_entry dg1_mocs_table[] = {
> -
> /* UC */
> MOCS_ENTRY(1, 0, L3_1_UC),
> /* WB - L3 */
> --
> 2.47.2
The patch looks good to me.
Reviewed-by: Nitin Gote <nitin.r.gote@xxxxxxxxx>
