On 3/12/2025 10:37 PM, Gustavo Sousa wrote:
Quoting Jani Nikula (2025-03-11 15:08:48-03:00)
On Tue, 11 Mar 2025, Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> wrote:
Reorder the macros HAS_AS_SDP and HAS_CMRR as per alphabetical order.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
---
drivers/gpu/drm/i915/display/intel_display_device.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
index 717286981687..332647c4ca81 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -142,10 +142,12 @@ struct intel_display_platforms {
func(supports_tv);
#define HAS_4TILE(__display) ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14)
+#define HAS_AS_SDP(__display) (DISPLAY_VER(__display) >= 13)
#define HAS_ASYNC_FLIPS(__display) (DISPLAY_VER(__display) >= 5)
Y comes before _ in asciibetical order.
Maybe that's just me, but I feel that's counter-intuitive in a context
where we use _ to separate words.
I do agree. I was assuming that we sort the words separated by '_' as
delimiter.
For a given hypothetical list, I thought the ordering will result in
similar items grouped together
(please forgive me for making up silly names here)
HAS_HD
HAS_HD_AUDIO
HAS_HD_DISPLAY
HAS_HD_SUPPORT
HAS_HDMI
HAS_HDMI_PCON
HAS_HDR
But with the `sort` command it will be:
HAS_HD
HAS_HDMI
HAS_HDMI_PCON
HAS_HDR
HAS_HD_AUDIO
HAS_HD_DISPLAY
HAS_HD_SUPPORT
However, if majority of folks use editor's sort command it becomes
simpler to have the ASCII ordering for everyone.
Regards,
Ankit
--
Gustavo Sousa
BR,
Jani.
#define HAS_BIGJOINER(__display) (DISPLAY_VER(__display) >= 11 && HAS_DSC(__display))
#define HAS_CDCLK_CRAWL(__display) (DISPLAY_INFO(__display)->has_cdclk_crawl)
#define HAS_CDCLK_SQUASH(__display) (DISPLAY_INFO(__display)->has_cdclk_squash)
+#define HAS_CMRR(__display) (DISPLAY_VER(__display) >= 20)
#define HAS_CMTG(__display) (!(__display)->platform.dg2 && DISPLAY_VER(__display) >= 13)
#define HAS_CUR_FBC(__display) (!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13))
#define HAS_D12_PLANE_MINIMIZATION(__display) ((__display)->platform.rocketlake || (__display)->platform.alderlake_s)
@@ -189,8 +191,6 @@ struct intel_display_platforms {
((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
HAS_DSC(__display))
#define HAS_VRR(__display) (DISPLAY_VER(__display) >= 11)
-#define HAS_AS_SDP(__display) (DISPLAY_VER(__display) >= 13)
-#define HAS_CMRR(__display) (DISPLAY_VER(__display) >= 20)
#define INTEL_NUM_PIPES(__display) (hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
#define I915_HAS_HOTPLUG(__display) (DISPLAY_INFO(__display)->has_hotplug)
#define OVERLAY_NEEDS_PHYSICAL(__display) (DISPLAY_INFO(__display)->overlay_needs_physical)
--
Jani Nikula, Intel
