✗ Fi.CI.CHECKPATCH: warning for drm/i915: make i915->display opaque pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: make i915->display opaque pointer
URL   : https://patchwork.freedesktop.org/series/146155/
State : warning

== Summary ==

Error: dim checkpatch failed
86f3f992d5c6 drm/i915/hdmi: remove inline to_i915()
5ce6ca11f746 drm/i915/hotplug: use container_of() to get struct intel_display
9c2c38c55ec5 drm/i915: convert i915 and xe display members into pointers
860a600b42c0 drm/i915: scripted conversion to i915->display pointer
-:9: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#9: 
sed -i 's/&\([a-zA-Z0-9_>.-]*\)\(dev_priv\|i915\|xe\)->display\([^.]\)/\1\2->display\3/g' $(git ls-files -- drivers/gpu/drm/i915 drivers/gpu/drm/xe)

-:2413: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2413: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:699:
+		queue_work(dev_priv->display->hotplug.dp_wq, &dev_priv->display->hotplug.dig_port_work);

-:4105: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!dev_priv->display->hotplug.dp_wq"
#4105: FILE: drivers/gpu/drm/i915/i915_driver.c:138:
+	if (dev_priv->display->hotplug.dp_wq == NULL)

total: 0 errors, 2 warnings, 1 checks, 3987 lines checked
99c3a2833646 drm/i915: allocate struct intel_display dynamically
-:25: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*i915->display)...) over kzalloc(sizeof(struct intel_display)...)
#25: FILE: drivers/gpu/drm/i915/i915_driver.c:758:
+	i915->display = kzalloc(sizeof(struct intel_display), GFP_KERNEL);

-:52: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*xe->display)...) over kzalloc(sizeof(struct intel_display)...)
#52: FILE: drivers/gpu/drm/xe/display/xe_display.c:105:
+	xe->display = kzalloc(sizeof(struct intel_display), GFP_KERNEL);

total: 0 errors, 0 warnings, 2 checks, 34 lines checked
47b8a17052dd drm/i915: stop including display/intel_display_core.h from i915_drv.h
e96287a929be drm/xe: drop intel_display_core/device.h include from xe_device_types.h





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux