On Sat, Mar 08, 2025 at 01:48:50AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > Implement fixed-type BIT_U*() to help drivers add stricter checks, > like it was done for GENMASK_U*(). ... > /* > * Missing asm support > * > - * GENMASK_U*() depends on BITS_PER_TYPE() which relies on sizeof(), > - * something not available in asm. Nethertheless, fixed width integers > - * is a C concept. Assembly code can rely on the long and long long > - * versions instead. > + * GENMASK_U*() and BIT_U*() depend on BITS_PER_TYPE() which relies on > + * sizeof(), something not available in asm. Nethertheless, fixed > + * width integers is a C concept. Assembly code can rely on the long > + * and long long versions instead. > */ I don't like this hunk. You just introduced a message which is rewritten completely in the immediate followup. Can you come up in a better text here and/or there so it will give only + LoCs (or minimizes - to 1:ish)? -- With Best Regards, Andy Shevchenko
