s/selftest_lrc/selftests/ Disable lrc_timestamp test Quoting Mikolaj Wasiak (2025-03-07 13:16:48) > This test was supposed to show bug in tigerlake and dg2 hardware. s/supposed/designed/ s/show/isolate a/ > The bug was found and fixed in newer generations. > Since we won't support any new hardware with this driver, the test > should now be turned off in the CI to not polute it with random failures s/polute/pollute/ > on previous hardware. > > Signed-off-by: Mikolaj Wasiak <mikolaj.wasiak@xxxxxxxxx> > --- > Sorry for the duplicate, I've sent it to wrong mailing list. > > Fixes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697 You can keep the fixes in the main portion of the changelog for future reference. > > v1 -> v2: Disabled the test instead of removing it, > Change name from 'remove' to 'disable' > > drivers/gpu/drm/i915/gt/selftest_lrc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index 22e750108c5f..419a7cd61b65 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -3,6 +3,7 @@ > * Copyright © 2018 Intel Corporation > */ > > +#include "linux/kconfig.h" <linux/kconfig.h> > #include <linux/prime_numbers.h> > > #include "gem/i915_gem_internal.h" > @@ -858,6 +859,16 @@ static int live_lrc_timestamp(void *arg) > U32_MAX, > }; > > + /* > + * This test was created to show existence of hardware bug. > + * The bug was found and fixed in further generations but s/further/future/ > + * now this test polutes our CI on previous generations. s/polutes/pollutes/ > + * > + * https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697 > + */ > + if (!IS_ENABLED(CONFIG_DRM_I915_SELFTEST_BROKEN)) We could GRAPHICS_VER(i915) == 12 to illustrate the point more if you want. Nits notwithstanding, Reviewed-by: Chris Wilson <chris.p.wilson@xxxxxxxxxxxxxxx> -Chris
