On Wed, 05 Mar 2025, Ryszard Knop <rk@xxxxxxxxxxx> wrote: > On Wed, 2025-03-05 at 19:52 +0200, Jani Nikula wrote: >> I think eventually we will want to consider accepting contributions via >> gitlab merge requests directly. >> >> It would also be interesting if maintainers/committers could merge the >> contributions via gitlab UI already when CI applied the patches from the >> mailing list and created the merge request. >> >> In the merge request case, they'd have to be against individual repos >> that feed into drm-tip, *not* merge requests against drm-tip >> directly. So for testing CI would have to recreate drm-tip the same way >> as 'dim push-branch' currently does. > > This is doable, but perf-wise is not going to be great. We would have to > checkout all trees pulled into drm/tip for each build as listed in the > latest integration-manifest, replace target tree with the MR tree, then > provide results from that. We'll see how this works out in practice. > (It should be just `dim rebuild-tip` after pointing all the branches at > the required commits?) > > This also means having a backup drm/tip source when fd.o is offline is > out; it's patched into too many places if dim gets used. I think the short answer is, just go ahead with what you're planning now, but keep the above in the back of your mind. I'm not sure we have definitive answers without a bunch of planning yet either. BR, Jani. -- Jani Nikula, Intel