On Tue, 2025-02-18 at 23:19 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Update bw_state->active_pipes during readout.
>
> This was completely missing from the current readout code.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 0090ee7e73a1..30e6f33d6f30 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -1431,9 +1431,15 @@ void intel_bw_update_hw_state(struct intel_display *display)
> if (DISPLAY_VER(display) < 9)
> return;
>
> + bw_state->active_pipes = 0;
As active_pipes are already calculated in intel_modeset_readout_hw_state, wonder will it be useful
if we pass active_pipes as a parameter to this function and use it above?
Anyway,
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@xxxxxxxxx>
> +
> for_each_intel_crtc(display->drm, crtc) {
> const struct intel_crtc_state *crtc_state =
> to_intel_crtc_state(crtc->base.state);
> + enum pipe pipe = crtc->pipe;
> +
> + if (crtc_state->hw.active)
> + bw_state->active_pipes |= BIT(pipe);
>
> intel_bw_crtc_update(bw_state, crtc_state);
> }
