> -----Original Message----- > From: Yu, Gareth <gareth.yu@xxxxxxxxx> > Sent: Friday, February 28, 2025 6:46 AM > To: Kandpal, Suraj <suraj.kandpal@xxxxxxxxx> > Cc: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx; Nikula, Jani > <jani.nikula@xxxxxxxxx>; Shankar, Uma <uma.shankar@xxxxxxxxx>; Tseng, > William <william.tseng@xxxxxxxxx> > Subject: Re: [PATCH] drm/i915/vdsc: Use the DSC config tables for DSI panels > > > From mboxrd@z Thu Jan 1 00:00:00 1970 > > Return-Path: mailto:intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx > > X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on > > aws-us-west-2-korg-lkml-1.web.codeaurora.org > > Received: from gabe.freedesktop.org (gabe.freedesktop.org > [131.252.210.177]) > > (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 > bits)) > > (No client certificate requested) > > by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D23C19F2E > > for mailto:intel-xe@xxxxxxxxxxxxxxxxxxx; Thu, 27 Feb 2025 11:26:56 > > +0000 (UTC) > > Received: from gabe.freedesktop.org (localhost [127.0.0.1]) > > by gabe.freedesktop.org (Postfix) with ESMTP id A7C1C10EAB7; > > Thu, 27 Feb 2025 11:26:56 +0000 (UTC) > > Authentication-Results: gabe.freedesktop.org; > > dkim=pass (2048-bit key; unprotected) header.d=intel.com > mailto:header.i=@intel.com header.b="MY6Bt0hC"; > > dkim-atps=neutral > > Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) > > by gabe.freedesktop.org (Postfix) with ESMTPS id A87DB10EA9E; Thu, 27 > > Feb 2025 11:26:55 +0000 (UTC) > > DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; > > mailto:i=@intel.com; q=dns/txt; s=Intel; t=1740655616; x=1772191616; > > h=from:to:cc:subject:date:message-id:mime-version: > > content-transfer-encoding; > > bh=8+o+KH5SGXJL9pbefqym6H7zNpSc5021IPN/PdKwNsU=; > > b=MY6Bt0hCjt+GFDT82nKYuYZ8t3ShCcp4URQO/YXiWFVIhZbAZpbiMYzZ > > dpzC9aG2zCv1V3KglhDw6BgmJjGcnY/GDf0KD0me4MN1098RLXCbY3Zlo > > g68++M+uiF699gmgAasdx1BWFkcYysaszs8DBcyyFE7zNw7OM9f6Q5dzD > > VPmG6XxflXUYU7Mpij3Wn8vBQ9DPqwXzbPy1Iv5Ojis2Rb5CmpnP82HWK > > SJU6CUlgcuF1b7d0XTyBkYaQ/KjmdRVNsHW8cSMLvpzum54UtY2cmsrM3 > > dCeE+isV4RtwPDaWmX1SeEF9F7Y4cL+9vDj4NTM2INZqCfAY+UCM4aKiZ Q==; > > X-CSE-ConnectionGUID: gR/d5ikPS82kkQ2JSyF2KA== > > X-CSE-MsgGUID: GUC8x5VDRo+UNdtKbxA6/Q== > > X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="52527215" > > X-IronPort-AV: E=Sophos;i="6.13,319,1732608000"; > d="scan'208";a="52527215" > > Received: from orviesa001.jf.intel.com ([10.64.159.141]) by > > orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; > > 27 Feb 2025 03:26:56 -0800 > > X-CSE-ConnectionGUID: mUJY05jTSP2Aj3LHisZ5pw== > > X-CSE-MsgGUID: TtB54KpmQjOcHenFYonybQ== > > X-ExtLoop1: 1 > > X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; > d="scan'208";a="154180517" > > Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) > > by orviesa001.jf.intel.com with ESMTP; 27 Feb 2025 03:26:53 -0800 > > From: Suraj Kandpal mailto:suraj.kandpal@xxxxxxxxx > > To: mailto:intel-xe@xxxxxxxxxxxxxxxxxxxxx, > > mailto:intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: mailto:ankit.k.nautiyal@xxxxxxxxx, mailto:uma.shankar@xxxxxxxxx, > > mailto:william.tseng@xxxxxxxxx, mailto:jani.nikula@xxxxxxxxx, Suraj > > Kandpal mailto:suraj.kandpal@xxxxxxxxx > > Subject: [PATCH] drm/i915/vdsc: Use the DSC config tables for DSI > > panels > > Date: Thu, 27 Feb 2025 16:56:54 +0530 > > Message-Id: mailto:20250227112654.279160-1-suraj.kandpal@xxxxxxxxx > > X-Mailer: git-send-email 2.34.1 > > MIME-Version: 1.0 > > Content-Transfer-Encoding: 8bit > > X-BeenThere: mailto:intel-xe@xxxxxxxxxxxxxxxxxxxxx > > X-Mailman-Version: 2.1.29 > > Precedence: list > > List-Id: Intel Xe graphics driver <intel-xe.lists.freedesktop.org> > > List-Unsubscribe: > > https://lists.freedesktop.org/mailman/options/intel-xe, > > mailto:intel-xe-request@xxxxxxxxxxxxxxxxxxxxx?subject=unsubscribe > > List-Archive: https://lists.freedesktop.org/archives/intel-xe > > List-Post: mailto:intel-xe@xxxxxxxxxxxxxxxxxxxxx > > List-Help: mailto:intel-xe-request@xxxxxxxxxxxxxxxxxxxxx?subject=help > > List-Subscribe: > > https://lists.freedesktop.org/mailman/listinfo/intel-xe, > > mailto:intel-xe-request@xxxxxxxxxxxxxxxxxxxxx?subject=subscribe > > Errors-To: mailto:intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx > > Sender: "Intel-xe" mailto:intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx > > > > Some DSI panel vendors end up hardcoding PPS params because of which > > it does not listen to the params sent from the source. We use the > > default config tables for DSI panels when using DSC 1.1 rather than > > calculate our own rc parameters. > > > > --v2 > > -Use intel_crtc_has_type [Jani] > > > > --v3 > > -Add Signed-off-by from William too [Ankit] > > > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719 > > Signed-off-by: Suraj Kandpal mailto:suraj.kandpal@xxxxxxxxx > > Signed-off-by: William Tseng mailto:william.tseng@xxxxxxxxx > > --- > > drivers/gpu/drm/i915/display/intel_vdsc.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c > > b/drivers/gpu/drm/i915/display/intel_vdsc.c > > index 6e7151346382..affe9913f1ee 100644 > > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c > > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c > > @@ -320,7 +320,9 @@ int intel_dsc_compute_params(struct intel_crtc_state > *pipe_config) > > * upto uncompressed bpp-1, hence add calculations for all the rc > > * parameters > > */ > > - if (DISPLAY_VER(dev_priv) >= 13) { > > + if (DISPLAY_VER(dev_priv) >= 13 && > > Please change to "if (DISPLAY_VER(dev_priv) >= 14 &&" because MTL begins to > support DSC 1.2a according bspec 49259. As mentioned in the gitlab issue calculate_rc_params works for both DSC 1.1 and 1.2a because of which DISPLAY_VER>=13 works check commit message db514cac. The reason we saw the issue in DSI panels was individual DSI panel vendors hardcoding DSC params and not the driver Miscalculating them which would also explain why it worked for all other panels in platforms >=13. So won't be changing the display_ver() check. Regards, Suraj Kandpal > > > + (vdsc_cfg->dsc_version_minor != 1 || > > + intel_crtc_has_type(pipe_config, INTEL_OUTPUT_DSI))) { > > calculate_rc_params(vdsc_cfg); > > } else { > > if ((compressed_bpp == 8 || > > -- > > 2.34.1 >
