Quoting Matt Roper (2025-02-26 19:26:13-03:00)
>On Wed, Feb 26, 2025 at 11:08:46AM -0300, Gustavo Sousa wrote:
>> Workaround Wa_14020863754 also applies to Xe3_LPD. Update
>> needs_wa_14020863754() accordingly.
>
>It looks like this might also be needed for Xe2_HPD (version 14.01) as well?
Yep, display->platform.battlemage covers that today, but it would fail
to capture cases where Xe2_HDP get's re-used in another platform, if
that ever happens.
I'll send a second patch to convert that to use display version instead.
Thanks.
--
Gustavo Sousa
>
>
>Matt
>
>>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx>
>> ---
>> drivers/gpu/drm/i915/display/intel_audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
>> index aaba438ab41e3c1c06d609593dc40dff33785d3a..67344cdbd8196fcca99af5311cf39d8e9bd810a4 100644
>> --- a/drivers/gpu/drm/i915/display/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
>> @@ -190,7 +190,7 @@ static const struct hdmi_aud_ncts hdmi_aud_ncts_36bpp[] = {
>> */
>> static bool needs_wa_14020863754(struct intel_display *display)
>> {
>> - return DISPLAY_VER(display) == 20 || display->platform.battlemage;
>> + return IS_DISPLAY_VER(display, 20, 30) || display->platform.battlemage;
>> }
>>
>> /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
>>
>> ---
>> base-commit: 4a2f1c823287a84dc0bd46c5a93545dfe49967f2
>> change-id: 20250226-xe3lpd-wa-14020863754-5f11f757cf20
>>
>> Best regards,
>> --
>> Gustavo Sousa <gustavo.sousa@xxxxxxxxx>
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation
