On Mon, Feb 24, 2025 at 11:47:01AM +0530, Ankit Nautiyal wrote: > Switching between variable and fixed timings is possible as for that we > just need to flip between VRR timings. However for CMRR along with the > timings, few other bits also need to be changed on the fly, which might > cause issues. So disable CMRR for now, till we have variable and fixed > timings sorted out. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> Yeh, let's ponder this later. Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c > index 008a9c3e152d..0ee7fb0362ce 100644 > --- a/drivers/gpu/drm/i915/display/intel_vrr.c > +++ b/drivers/gpu/drm/i915/display/intel_vrr.c > @@ -182,7 +182,8 @@ is_cmrr_frac_required(struct intel_crtc_state *crtc_state) > int calculated_refresh_k, actual_refresh_k, pixel_clock_per_line; > struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > > - if (!HAS_CMRR(display)) > + /* Avoid CMRR for now till we have VRR with fixed timings working */ > + if (!HAS_CMRR(display) || true) > return false; > > actual_refresh_k = > -- > 2.45.2 -- Ville Syrjälä Intel
