On Tue, 2025-02-18 at 23:18 +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > The crtc state is expected to be fully cleared before readout, > so there is no need to clear the shared_dpll pointers by hand. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_display.c | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Vinod Govindapillai <vinod.govindapillai@xxxxxxxxx> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index cb9c6ad3aa11..8ee8c1df075a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -3121,7 +3121,6 @@ static bool i9xx_get_pipe_config(struct intel_crtc *crtc, > pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB; > pipe_config->sink_format = pipe_config->output_format; > pipe_config->cpu_transcoder = (enum transcoder) crtc->pipe; > - pipe_config->shared_dpll = NULL; > > ret = false; > > @@ -3503,7 +3502,6 @@ static bool ilk_get_pipe_config(struct intel_crtc *crtc, > return false; > > pipe_config->cpu_transcoder = (enum transcoder) crtc->pipe; > - pipe_config->shared_dpll = NULL; > > ret = false; > tmp = intel_de_read(dev_priv, > @@ -4080,8 +4078,6 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc, > POWER_DOMAIN_PIPE(crtc->pipe))) > return false; > > - pipe_config->shared_dpll = NULL; > - > active = hsw_get_transcoder_state(crtc, pipe_config, &crtc->hw_readout_power_domains); > > if ((IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv)) &&