On Thu, 13 Feb 2025, "Kandpal, Suraj" <suraj.kandpal@xxxxxxxxx> wrote:
>> @@ -1941,12 +1942,13 @@ static enum drm_mode_status
>> intel_sdvo_mode_valid(struct drm_connector *connector,
>> const struct drm_display_mode *mode) {
>> + struct intel_display *display = to_intel_display(connector->dev);
>
> Why not &i915->display and declare this after i915 declaration
Because i915 will go away eventually, and I don't want to have to change
this line again.
BR,
Jani.
>
> Otherwise LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
>
>
>> struct drm_i915_private *i915 = to_i915(connector->dev);
>> struct intel_sdvo *intel_sdvo =
>> intel_attached_sdvo(to_intel_connector(connector));
>> struct intel_sdvo_connector *intel_sdvo_connector =
>> to_intel_sdvo_connector(connector);
>> bool has_hdmi_sink = intel_has_hdmi_sink(intel_sdvo_connector,
>> connector->state);
>> - int max_dotclk = i915->display.cdclk.max_dotclk_freq;
>> + int max_dotclk = display->cdclk.max_dotclk_freq;
>> enum drm_mode_status status;
>> int clock = mode->clock;
>>
--
Jani Nikula, Intel
