✗ Fi.CI.CHECKPATCH: warning for drm_i915_private to intel_display cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm_i915_private to intel_display cleanup
URL   : https://patchwork.freedesktop.org/series/144588/
State : warning

== Summary ==

Error: dim checkpatch failed
32c4709d5b05 drm/i915/display_debug_fs: Use intel_display wherever possible
-:50: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63)
#50: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:95:
+	if (DISPLAY_VER(display) >= 9)
 		/* no global SR status; inspect per-plane WM */;

total: 0 errors, 1 warnings, 0 checks, 506 lines checked
e1e6d78a31d4 drm/i915/display_debug_fs: Prefer using display->platform
1287b80ea795 drm/i915/dpll: Change param to intel_display in for_each_shared_dpll
-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects?
#141: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:33:
+#define for_each_shared_dpll(__display, __pll, __i) \
+	for ((__i) = 0; (__i) < (__display)->dpll.num_shared_dpll && \
+		     ((__pll) = &(__display)->dpll.shared_dplls[(__i)]) ; (__i)++)

-:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#141: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.h:33:
+#define for_each_shared_dpll(__display, __pll, __i) \
+	for ((__i) = 0; (__i) < (__display)->dpll.num_shared_dpll && \
+		     ((__pll) = &(__display)->dpll.shared_dplls[(__i)]) ; (__i)++)

total: 0 errors, 0 warnings, 2 checks, 218 lines checked
287807d6272c drm/i915/dpll: Use intel_display for dpll dump and compare hw state
7cdf02a408e5 drm/i915/dpll: Use intel_display possible in shared_dpll_mgr hooks
c58283fbb668 drm/i915/dpll: Use intel_display for asserting pll
56c83139b247 drm/i915/dpll: Use intel_display for update_refclk hook
3a05c299ceb6 drm/i915/dpll: Accept intel_display as argument for shared_dpll_init
af43425ee3a0 drm/i915/dpll: Replace all other leftover drm_i915_private





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux