== Series Details == Series: drm/i915: intel_display conversions and some debug improvements (rev3) URL : https://patchwork.freedesktop.org/series/143942/ State : warning == Summary == Error: dim checkpatch failed 26a11c6c5df4 drm/i915: Pass intel_display to intel_scanout_needs_vtd_wa() fc98c883aa80 drm/i915: Decouple i915_gem_dumb_create() from the display a bit e7709bd6414a drm/i915: Decouple intel_fb_bo.h interfaces from driver specific types 5a67abd07da5 drm/i915: Convert intel_crtc.c to struct intel_display c966f9ada1d8 drm/i915: Convert intel_fb.c to struct intel_display -:416: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #416: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1462: +#define assign_chk_ovf(display, var, val) ({ \ + drm_WARN_ON((display)->drm, overflows_type(val, var)); \ (var) = (val); \ }) -:416: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #416: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1462: +#define assign_chk_ovf(display, var, val) ({ \ + drm_WARN_ON((display)->drm, overflows_type(val, var)); \ (var) = (val); \ }) -:422: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #422: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1467: +#define assign_bfld_chk_ovf(display, var, val) ({ \ (var) = (val); \ + drm_WARN_ON((display)->drm, (var) != (val)); \ (var); \ }) -:422: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #422: FILE: drivers/gpu/drm/i915/display/intel_fb.c:1467: +#define assign_bfld_chk_ovf(display, var, val) ({ \ (var) = (val); \ + drm_WARN_ON((display)->drm, (var) != (val)); \ (var); \ }) total: 0 errors, 0 warnings, 4 checks, 871 lines checked e526752f9123 drm/i915: Convert intel_display_power_{get, put}*() to intel_display -:1529: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'display' - possible side-effects? #1529: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299: +#define with_intel_display_power(display, domain, wf) \ + for ((wf) = intel_display_power_get((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) -:1529: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects? #1529: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299: +#define with_intel_display_power(display, domain, wf) \ + for ((wf) = intel_display_power_get((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) -:1529: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #1529: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:299: +#define with_intel_display_power(display, domain, wf) \ + for ((wf) = intel_display_power_get((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) -:1536: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'display' - possible side-effects? #1536: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303: +#define with_intel_display_power_if_enabled(display, domain, wf) \ + for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) -:1536: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'domain' - possible side-effects? #1536: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303: +#define with_intel_display_power_if_enabled(display, domain, wf) \ + for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) -:1536: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #1536: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:303: +#define with_intel_display_power_if_enabled(display, domain, wf) \ + for ((wf) = intel_display_power_get_if_enabled((display), (domain)); (wf); \ + intel_display_power_put_async((display), (domain), (wf)), (wf) = NULL) total: 0 errors, 0 warnings, 6 checks, 2373 lines checked f04becfe2bf9 drm/i915: Convert i9xx_plane.c to struct intel_display 457af0273faf drm/i915: Finish intel_sprite.c struct intel_display conversion d5e200b3c9f3 drm/i915: Convert intel_cursor.c to struct intel_display 55a222180643 drm/i915: Convert skl_univeral_plane.c to struct intel_display -:1134: WARNING:IS_ENABLED_CONFIG: IS_ENABLED(I915) is normally used as IS_ENABLED(CONFIG_I915) #1134: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:2808: + if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(to_i915(display->drm))) total: 0 errors, 1 warnings, 0 checks, 1225 lines checked 041b800d4160 drm/i915: Use DRM_RECT_FMT & co. for plane debugs -:39: WARNING:LONG_LINE: line length of 111 exceeds 100 columns #39: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:963: + drm_dbg_kms(&i915->drm, "Plane (" DRM_RECT_FMT ") must cover entire CRTC (" DRM_RECT_FMT ")\n", total: 0 errors, 1 warnings, 0 checks, 23 lines checked 4c7b83ae1209 drm/i915: Pimp plane debugs -:81: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #81: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:949: + "[PLANE:%d:%s] invalid scaling "DRM_RECT_FP_FMT " -> " DRM_RECT_FMT "\n", -:92: WARNING:LONG_LINE: line length of 113 exceeds 100 columns #92: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:966: + "[PLANE:%d:%s] plane (" DRM_RECT_FMT ") must cover entire CRTC (" DRM_RECT_FMT ")\n", total: 0 errors, 1 warnings, 1 checks, 378 lines checked
