Re: [PATCH v2] drm/i915/selftests: avoid using uninitialized context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof

> +	if (!ppgtt->vm.allocate_va_range) {
> +	        i915_vm_put(&ppgtt->vm);
> +	        return 0;
> +	}

I don't know if it feels more in line with kernel style, but consider
changing it to a label before second `i915_vm_put` at end of function
plus goto instead of creating new cleanup section.

Otherwise looks alright.
Reviewed-by: Mikolaj Wasiak <mikolaj.wasiak@xxxxxxxxx>

Mikolaj



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux