Hi Zhanjun There is a missing newline at drm-tip/drivers/gpu/drm/i915/gt/intel_rps.c:249 Overall, LGTM. On Thu Jan 23, 2025 at 4:23 PM UTC, Zhanjun Dong wrote: > The purpose of synchronize_irq is to wait for any pending IRQ handlers for the > interrupt to complete, if synchronize_irq called before interrupt disabled, an > tiny timing window created, where no more pending IRQ, but interrupt not > disabled yet. Meanwhile, if the interrupt event happened in this timing window, > an unexpected IRQ handling will be triggered. > > Fixed by always disable interrupt ahead of synchronize_irq. > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13454 > Fixes: 26705e20752a ("drm/i915: Support for GuC interrupts") > Fixes: 54c52a841250 ("drm/i915/guc: Correctly handle GuC interrupts on Gen11") > Fixes: 2ae096872a2c ("drm/i915/pxp: Implement PXP irq handler") > Fixes: 3e7abf814193 ("drm/i915: Extract GT render power state management") > > Signed-off-by: Zhanjun Dong <zhanjun.dong@xxxxxxxxx> > Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@xxxxxxxxx> -- Best regards, Sebastian
