On Thu Jan 23, 2025 at 1:54 PM UTC, Krzysztof Niemiec wrote: > Hi Sebastian, > > On 2025-01-23 at 11:33:00 GMT, Sebastian Brzezinka wrote: >> This reverts commit 835443da6f50d9516b58bba5a4fdf9e563d961c7. >> >> Kernel taint information is present in dmesg already, and in >> the case of an unrecoverable error, the CI restarts the device >> accordingly. Raising an error causes intentional error injection >> to report an undesired error notification. >> >> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@xxxxxxxxx> > > I'd rephrase the last sentence of the commit log a bit. It's a little > unclear why the patch should be reverted, e.g.: > > - turns out that logging with gt_err() causes CI to pick up an error > even in intentional error injects, > - the unintentional (real) errors are already reported correctly by CI, > - a gt wedge is already being logged without this patch, so we should > revert the new message instead of, for example, relaxing the loglevel. > > I obviously have the context on this so I know exactly what's happening, > but the maintainers might not be as familiar with the issue, so going > into more detail in the patch log would be good. > > Thanks > Krzysztof Thank you for the review, I sent a second version with a corrected commit message. -- Best regards, Sebastian Brzezinka
