> -----Original Message-----
> From: Nikula, Jani <jani.nikula@xxxxxxxxx>
> Sent: Monday, January 20, 2025 4:22 PM
> To: Kandpal, Suraj <suraj.kandpal@xxxxxxxxx>; intel-xe@xxxxxxxxxxxxxxxxxxxxx;
> intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>; Bhadane, Dnyaneshwar
> <dnyaneshwar.bhadane@xxxxxxxxx>; Kandpal, Suraj
> <suraj.kandpal@xxxxxxxxx>
> Subject: Re: [PATCH] drm/i915/hdcp: Use correct function to check if encoder
> is HDMI
>
> On Fri, 17 Jan 2025, Suraj Kandpal <suraj.kandpal@xxxxxxxxx> wrote:
> > Use intel_encoder_is_hdmi function which was recently introduced to
> > see if encoder is HDMI or not.
> >
> > --v2
> > -Add Fixes tag [Jani]
> >
> > Fixes: 6a3691ca4799 ("drm/i915/hdcp: Disable HDCP Line Rekeying for
> > HDCP2.2 on HDMI")
> > Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Thanks for the review pushed to din
Regards,
Suraj Kandpal
>
> > ---
> > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > index 7464b44c8bb3..91d5629cd9f9 100644
> > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > @@ -41,7 +41,7 @@ intel_hdcp_adjust_hdcp_line_rekeying(struct
> intel_encoder *encoder,
> > u32 rekey_bit = 0;
> >
> > /* Here we assume HDMI is in TMDS mode of operation */
> > - if (encoder->type != INTEL_OUTPUT_HDMI)
> > + if (!intel_encoder_is_hdmi(encoder))
> > return;
> >
> > if (DISPLAY_VER(display) >= 30) {
>
> --
> Jani Nikula, Intel
