Re: [PATCH v3 2/8] drm/i915/gvt: fix typos in i915/gvt files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nitin,

...

> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 6439c8e91a8d..f8af9659653d 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -1924,7 +1924,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
>  	/* the start_offset stores the batch buffer's start gma's
>  	 * offset relative to page boundary. so for non-privileged batch

The comment format should be changed here and "so" should be
capitalized; as other reviewers suggested, you could use this chance to
fix those while you're at it.

>  	 * buffer, the shadowed gem object holds exactly the same page
> -	 * layout as original gem object. This is for the convience of
> +	 * layout as original gem object. This is for the convenience of
>  	 * replacing the whole non-privilged batch buffer page to this
>  	 * shadowed one in PPGTT at the same gma address. (this replacing

Nit: either "this" should be capitalized or the dot ending the sentence
before the parenthesis should be removed.

>  	 * action is not implemented yet now, but may be necessary in

...

> diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
> index 23f2cc397ec9..dad217df0366 100644
> --- a/drivers/gpu/drm/i915/gvt/scheduler.c
> +++ b/drivers/gpu/drm/i915/gvt/scheduler.c
> @@ -77,7 +77,7 @@ static void update_shadow_pdps(struct intel_vgpu_workload *workload)
>  }
>  
>  /*
> - * when populating shadow ctx from guest, we should not overrride oa related
> + * when populating shadow ctx from guest, we should not override oa related
>   * registers, so that they will not be overlapped by guest oa configs. Thus
>   * made it possible to capture oa data from host for both host and guests.
>   */
> @@ -528,7 +528,7 @@ static int prepare_shadow_batch_buffer(struct intel_vgpu_workload *workload)
>  	int ret;
>  
>  	list_for_each_entry(bb, &workload->shadow_bb, list) {
> -		/* For privilge batch buffer and not wa_ctx, the bb_start_cmd_va
> +		/* For privilege batch buffer and not wa_ctx, the bb_start_cmd_va

Comment style can be corrected here.

>  		 * is only updated into ring_scan_buffer, not real ring address
>  		 * allocated in later copy_workload_to_ring_buffer. pls be noted
>  		 * shadow_ring_buffer_va is now pointed to real ring buffer va
> @@ -1774,7 +1774,7 @@ intel_vgpu_create_workload(struct intel_vgpu *vgpu,
>  }
>  

Thanks
Krzysztof



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux