Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacek,

> >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> >> @@ -110,6 +110,7 @@ static int i915_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *
> >>  	if (ret)
> >>  		return ret;
> >>  
> >> +	vm_flags_set(vma, VM_DONTEXPAND);
> >>  	vma_set_file(vma, obj->base.filp);
> >>  
> >>  	return 0;
> >>
> > Is this an existing issue somewhere (on GitLab for example)? The fix
> > looks good, I'm just curious how you noticed this problem and if the
> > patch should have "Fixes/Closes" labels added.
> 
> We noticed the problem while running internal intel_vpu tests that import buffers from vulkan.
> These tests will be upstreamed at some point but currently there is no external issue for this bug.
Having a test for that would be beneficial - it would let us verify the
necessity of this commit. Looking forward to it :)

> I will add Fixes tag.
Please do, having a reference point would be good.

After you add that:
Reviewed-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx>

Krzysztof




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux