On Thu, 05 Dec 2024, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Thu, Dec 05, 2024 at 05:03:00PM +0200, Jani Nikula wrote:
>> Building with clang and and W=1 leads to warning about unused
>> rcar_cmm_read(). Fix by annotating it with __maybe_unused.
>>
>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> inline functions for W=1 build").
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> https://lore.kernel.org/r/20240911095113.GB4470@xxxxxxxxxxxxxxxxxxxxxxxxxx
>
> I wonder if Dave and Sima are starting to ignore my pull request in the
> hope I'll switch to using drm-misc :-S I'll send another one.
Have you sent the pull request again? I haven't seen one.
BR,
Jani.
>
>> ---
>>
>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> Cc: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
>> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
>> ---
>> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
>> index 26a2f5ad8ee5..ea52b0af9226 100644
>> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
>> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
>> @@ -32,7 +32,7 @@ struct rcar_cmm {
>> } lut;
>> };
>>
>> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
>> +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
>> {
>> return ioread32(rcmm->base + reg);
>> }
--
Jani Nikula, Intel
