On Thu, Dec 19, 2024 at 11:33:54PM +0200, Jani Nikula wrote:
> The crtc_state->pbn member is only used as a temporary variable within
> mst_stream_find_vcpi_slots_for_bpp(). Remove it as unnecessary.
>
> Suggested-by: Imre Deak <imre.deak@xxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_display_types.h | 2 --
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +--
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index eb9dd1125a4a..16e2bbde76eb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1160,8 +1160,6 @@ struct intel_crtc_state {
>
> bool double_wide;
>
> - int pbn;
> -
> struct intel_crtc_scaler_state scaler_state;
>
> /* w/a for waiting 2 vblanks during crtc enable */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index f7b91cf32b5b..51f0248084b6 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -321,14 +321,13 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
> * first branch device's link also applies here.
> */
> pbn.full = remote_tu * mst_state->pbn_div.full;
> - crtc_state->pbn = dfixed_trunc(pbn);
>
> drm_WARN_ON(display->drm, remote_tu < crtc_state->dp_m_n.tu);
> crtc_state->dp_m_n.tu = remote_tu;
>
> slots = drm_dp_atomic_find_time_slots(state, &intel_dp->mst_mgr,
> connector->port,
> - crtc_state->pbn);
> + dfixed_trunc(pbn));
> if (slots == -EDEADLK)
> return slots;
>
> --
> 2.39.5
>
