Re: [PATCH 1/3] drm/i915: Remove deadcode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tvrtko,

I did plan to take care of these patches, anyway, thanks for
doing it. Just a couple of notes: please add a cover letter to
explain where this comes from and...

On Fri, Dec 27, 2024 at 11:37:52AM +0000, Tvrtko Ursulin wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> 
> i915_active_acquire_for_context() was added in 2020 by
> commit 5d9341370f57 ("drm/i915: Export a preallocate variant of
> i915_active_acquire()") but has never been used.
> 
> The last use of __i915_gem_object_is_lmem() was removed in 2021 by
> commit ff20afc4cee7 ("drm/i915: Update error capture code to avoid using
> the current vma state")
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

... your SoB here, as well.

The BATs failed, so that I retriggered the tests.

Thanks,
Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux