Re: [PATCH] drm/i915/gt: Log reason for setting TAINT_WARN at reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sebastian,

On Thu, Dec 19, 2024 at 03:31:52PM +0000, Sebastian Brzezinka wrote:
> TAINT_WARN is used to notify CI about non-recoverable failures, which
> require device to be restarted. In some cases, there is no sufficient
> information about the reason for the restart. The test runner is just
> killed, and DUT is rebooted, logging only 'probe with driver i915 failed
> with error -4' to dmesg.
> 
> Printing error to dmesg before TAINT_WARN, would explain why the device
> has been restarted, and what caused the malfunction in the first place.
> 
> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@xxxxxxxxx>

thanks for fixing the commit log, but please, remember to add the
versioning and (git format-patch -v 2 ...) and the changelog.

For this time I will take it as it is, but next time, please keep
it in mind.

Thanks,
Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux