[Public] Hi Imre, Thanks for the patch set! Patch 1~4 & patch 6 & patch 8 are: Acked-by: Wayne Lin <Wayne.Lin@xxxxxxx> > -----Original Message----- > From: Imre Deak <imre.deak@xxxxxxxxx> > Sent: Monday, December 16, 2024 8:24 PM > To: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) > <Sunpeng.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Deucher, > Alexander <Alexander.Deucher@xxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Lyude Paul > <lyude@xxxxxxxxxx>; Karol Herbst <kherbst@xxxxxxxxxx>; Danilo Krummrich > <dakr@xxxxxxxxxx>; Jani Nikula <jani.nikula@xxxxxxxxx> > Subject: Re: [PATCH v3 04/11] drm/dp_mst: Register connectors via > drm_connector_dynamic_register() > > Hi Harry, Leo, Alex, Wayne, > > could you please ack this change? > > Thanks, > Imre > > On Thu, Dec 12, 2024 at 01:03:21AM +0200, Imre Deak wrote: > > MST connectors should be initialized/registered by calling > > drm_connector_dynamic_init()/drm_connector_dynamic_register(). The > > previous patch adding these functions explains the issue with the > > current drm_connector_init*()/drm_connector_register() interface for > > MST connectors. > > > > Based on the above adjust here the registration part and change the > > initialization part in follow-up patches for each driver. > > > > For now, drivers are allowed to keep using the drm_connector_init*() > > functions, by drm_connector_dynamic_register() checking for this (see > > drm_connector_add()). A patch later will change this to WARN in such > > cases. > > > > Cc: Lyude Paul <lyude@xxxxxxxxxx> > > Cc: Harry Wentland <harry.wentland@xxxxxxx> > > Cc: Leo Li <sunpeng.li@xxxxxxx> > > Cc: Wayne Lin <wayne.lin@xxxxxxx> > > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > > Cc: Karol Herbst <kherbst@xxxxxxxxxx> > > Cc: Danilo Krummrich <dakr@xxxxxxxxxx> > > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > > --- > > drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c > > b/drivers/gpu/drm/display/drm_dp_mst_topology.c > > index 687c70308d82b..f8cd094efa3c0 100644 > > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c > > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c > > @@ -2281,7 +2281,7 @@ drm_dp_mst_port_add_connector(struct > drm_dp_mst_branch *mstb, > > port->cached_edid = drm_edid_read_ddc(port->connector, > > &port->aux.ddc); > > > > - drm_connector_register(port->connector); > > + drm_connector_dynamic_register(port->connector); > > return; > > > > error: > > -- > > 2.44.2 > > -- Regards, Wayne Lin
